On ti, 2016-10-11 at 12:03 -0700, Robert Bragg wrote:
> > > +               case DRM_I915_PERF_PROP_MAX:
> > > +                       BUG();
> > 
> > We already handle this case above, but I guess we still need this in
> > order to silence gcc...
> right, and preferable to having a default: case, for the future compiler 
> warning to handle any new properties here.

Please, do use MISSING_CASE instead. Daniel is known to get upset for
far less ;)

Generally consensus is that BUG() is used only when there're no other options 
to back out.

Regards, Joonas
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
Intel-gfx mailing list

Reply via email to