On Fri, Jan 20, 2017 at 04:28:44PM +0200, Ander Conselvan de Oliveira wrote:
> Parameters tile_size, tile_width and tile_height were passed in the
> wrong order to _intel_adjust_tile_offset() when calculating the rotated
> offsets.
>
> This doesn't fix any user visible bug, since for packaged formats new
> and old offset are the same and the rotated offsets are within a tile
> before they are fed to _intel_adjust_tile_offset(). In that case, the
> offsets are unchanged. That is not true for planar formats, but those
> are currently not supported.
>
> Found by coverity.
>
> Fixes: 66a2d927cb0e ("drm/i915: Make intel_adjust_tile_offset() work for
> linear buffers")
> Cc: Ville Syrjälä <[email protected]>
> Cc: Sivakumar Thulasimani <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: [email protected]
> Cc: <[email protected]> # v4.9+
> Signed-off-by: Ander Conselvan de Oliveira
> <[email protected]>
Reviewed-by: Ville Syrjälä <[email protected]>
/me should really dig up whatever fb offset tests I had written earlier
and try to finish then...
> ---
> drivers/gpu/drm/i915/intel_display.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index bddadd9..0759e8b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2578,8 +2578,9 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,
> * We only keep the x/y offsets, so push all of the
> * gtt offset into the x/y offsets.
> */
> - _intel_adjust_tile_offset(&x, &y, tile_size,
> - tile_width, tile_height,
> pitch_tiles,
> + _intel_adjust_tile_offset(&x, &y,
> + tile_width, tile_height,
> + tile_size, pitch_tiles,
> gtt_offset_rotated *
> tile_size, 0);
>
> gtt_offset_rotated += rot_info->plane[i].width *
> rot_info->plane[i].height;
> --
> 2.5.5
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
