On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> As we add new generations, we should keep detecting new pre-production
> system development platforms that were temporarily enabled to facilitate
> initial development and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.
>
> v2: s/sdv/pre/ - not all system development vehicles are for
> preproduction usage.
>
> Signed-off-by: Chris Wilson <[email protected]>
> Cc: "Zanoni, Paulo R" <[email protected]>
> Cc: Rodrigo Vivi <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Ville Syrjälä <[email protected]>
<SNIP>
> static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> {
> - if (IS_HSW_EARLY_SDV(dev_priv) ||
> - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> + bool pre = false;
> +
> + pre |= IS_HSW_EARLY_SDV(dev_priv);
> + pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
Did you compare the asm with "pre = pre || ..."?
Reviewed-by: Joonas Lahtinen <[email protected]>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
