On Tue, 28 Feb 2017, Joonas Lahtinen <[email protected]> wrote: > On ti, 2017-02-28 at 13:11 +0200, Jani Nikula wrote: >> Leave the runtime check in place in case the platform variable itself >> comes from bogus sources. >> >> Signed-off-by: Jani Nikula <[email protected]> > > <SNIP> > >> @@ -890,6 +890,7 @@ enum intel_platform { >> INTEL_BROXTON, >> INTEL_KABYLAKE, >> INTEL_GEMINILAKE, >> + INTEL_MAX_PLATFORMS >> }; > > Easily confused to be be off by one, INTEL_MAX_PLATFORMS = > INTEL_GEMINILAKE, so I suggest changing it to INTEL_NUM_PLATFORMS which > is explicit.
...and wrong. INTEL_MAX_PLATFORMS is not the same as number of supported platforms. BR, Jani. > > Regards, Joonas -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
