On 06/12/2012 11:36 AM, Daniel Vetter wrote:
> This function is supposed to be used at mode set time, so prevent
> against future mistakes by adding a WARN().
> 
> Based on a patch by Paulo Zanoni, with the check extracted into a
> little assert_hdmi_port_disabled helper added to make things self
> documenting and move the assert stuff out of line.
> 
> Cc: Paulo Zanoni <[email protected]>
> Signed-Off-by: Daniel Vetter <[email protected]>

Apart from a typo in 'expectin' below:

Reviewed-by: Eugeni Dodonov <[email protected]>

> +     WARN(I915_READ(intel_hdmi->sdvox_reg) & enabled_bits,
> +          "HDMI port enabled, expectin disabled\n");
                                 ^^
Eugeni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to