On Thu, Mar 30, 2017 at 10:26:24AM -0400, Harry Wentland wrote: > Reviewed-by: Harry Wentland <[email protected]>
Thanks for the quick review, pushed to drm-misc. -Daniel > > On 2017-03-30 09:32 AM, Daniel Vetter wrote: > > With the explicit retry loop static analyzers get confused by the > > control flow and believe that e could be accessed after kfree. That's > > not possible, but it's non-obvious, so let's clear it to NULL. > > > > We already cleared e = NULL at the top of the function, so this is all > > in line. > > > > Cc: Julia Lawall <[email protected]> > > Reported-by: Julia Lawall <[email protected]> > > Fixes: 29dc0d1de182 ("drm: Roll out acquire context for the page_flip > > ioctl") > > Cc: Harry Wentland <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Jani Nikula <[email protected]> > > Cc: Sean Paul <[email protected]> > > Signed-off-by: Daniel Vetter <[email protected]> > > --- > > drivers/gpu/drm/drm_plane.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > > index ec62221d64a9..3a6de27bafed 100644 > > --- a/drivers/gpu/drm/drm_plane.c > > +++ b/drivers/gpu/drm/drm_plane.c > > @@ -922,6 +922,7 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, > > ret = drm_event_reserve_init(dev, file_priv, &e->base, > > &e->event.base); > > if (ret) { > > kfree(e); > > + e = NULL; > > goto out; > > } > > } > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
