On ma, 2017-04-10 at 09:55 +0100, Chris Wilson wrote: > 2 clflushes on two different objects are not ordered, and so do not > belong to the same timeline (context). Either we use a unique context > for each, or we reserve a special global context to mean unordered. > Ideally, we would reserve 0 to mean unordered (DMA_FENCE_NO_CONTEXT) to > have the same semantics everywhere. > > Signed-off-by: Chris Wilson <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Joonas Lahtinen <[email protected]>
<SNIP> > @@ -157,7 +156,7 @@ void i915_gem_clflush_object(struct drm_i915_gem_object > *obj, > dma_fence_init(&clflush->dma, > &i915_clflush_ops, > &clflush_lock, > - clflush_context, > + to_i915(obj->base.dev)->mm.unordered_timeline, It seems you have high confidence on being able to replace this line with DMA_FENCE_NO_CONTEXT ;) Reviewed-by: Joonas Lahtinen <[email protected]> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
