On 5/18/2017 2:16 PM, Chris Wilson wrote:
On Thu, May 18, 2017 at 02:11:15PM -0700, Michel Thierry wrote:
And store the active request so that we only search for it once; this
applies for reset-engine and full reset.
v2: Check for request completion inside _prepare_engine, don't use
ECANCELED, remove unnecessary null checks (Chris).
v3: Capture active requests during reset_prepare and store it the
engine hangcheck obj.
v4: Rename commit, change i915_gem_reset_request to just confirm the
active_request is still incomplete, instead of engine_stalled (Chris).
v5: With style; pass the active request to gem_reset_engine, keep single
return in reset_prepare_engine (Chris).
Suggested-by: Chris Wilson <[email protected]>
Signed-off-by: Michel Thierry <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
I would order this earlier in the series, i.e. make the change to store
the active_request and pass the request onwards in the global reset
handler first.
-Chris
ok, I'll move it to the beginning of the reset-engine series (which I
plan to resend soon).
Thanks for the review.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
