Chris Wilson <[email protected]> writes: > Quoting Mika Kuoppala (2017-07-20 14:31:31) >> Chris Wilson <[email protected]> writes: >> >> > When we wedge the device, we clear out the in-flight requests and >> > advance the breadcrumb to indicate they are complete. However, the >> > breadcrumb advance includes an assert that the engine is idle, so that >> > advancement needs to be the last step to ensure we pass our own sanity >> > checks. >> >> I am confused about this one. The previous patch seems to make >> the concern void. > > Yeah, I moved the assert around, but still felt the order imposed by > the memory of that assert was better.
Agreet that the ordering is better. If you swap these two patches around, you dont have to change the commit msg. Otherwise change false notion that there is assert in this path. Reviewed-by: Mika Kuoppala <[email protected]> _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
