Hello Xu Han,
The patch 5cf5fe8f729b: "drm/i915/gvt: Update MMIO handle policy to
compatible KBL platform." from Mar 29, 2017, leads to the following
static checker warning:
drivers/gpu/drm/i915/gvt/handlers.c:2855 init_skl_mmio_info()
'0x6 | 0x4' has '0x4' set on both sides
drivers/gpu/drm/i915/gvt/handlers.c
2848 MMIO_D(0x44500, D_SKL_PLUS);
2849 MMIO_DFH(GEN9_CSFE_CHICKEN1_RCS, D_SKL_PLUS, F_CMD_ACCESS,
NULL, NULL);
2850 MMIO_DFH(GEN8_HDC_CHICKEN1, D_SKL | D_KBL, F_MODE_MASK |
F_CMD_ACCESS,
2851 NULL, NULL);
2852
2853 MMIO_D(0x4ab8, D_KBL);
2854 MMIO_D(0x940c, D_SKL_PLUS);
2855 MMIO_D(0x2248, D_SKL_PLUS | D_KBL);
D_SKL_PLUS is the same as D_SKL | D_KBL so the D_KBL is redundant. Also
why don't we just use D_SKL_PLUS on the lines below as well?
2856 MMIO_D(0x4ab0, D_SKL | D_KBL);
2857 MMIO_D(0x20d4, D_SKL | D_KBL);
2858
2859 return 0;
2860 }
regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
