Hi Maarten,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20170904]
[cannot apply to v4.13]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-atomic-Move-drm_crtc_commit-to-drm_crtc_state-v4/20170905-011023
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-randconfig-x016-201736 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/drm_atomic_helper.c: In function 
'drm_atomic_helper_commit_hw_done':
>> drivers/gpu//drm/drm_atomic_helper.c:1850:26: error: void value not ignored 
>> as it ought to be
      old_crtc_state->commit = drm_crtc_commit_get(commit);
                             ^

vim +1850 drivers/gpu//drm/drm_atomic_helper.c

  1814  
  1815  /**
  1816   * drm_atomic_helper_commit_hw_done - setup possible nonblocking commit
  1817   * @old_state: atomic state object with old state structures
  1818   *
  1819   * This function is used to signal completion of the hardware commit 
step. After
  1820   * this step the driver is not allowed to read or change any permanent 
software
  1821   * or hardware modeset state. The only exception is state protected by 
other
  1822   * means than &drm_modeset_lock locks.
  1823   *
  1824   * Drivers should try to postpone any expensive or delayed cleanup work 
after
  1825   * this function is called.
  1826   *
  1827   * This is part of the atomic helper support for nonblocking commits, 
see
  1828   * drm_atomic_helper_setup_commit() for an overview.
  1829   */
  1830  void drm_atomic_helper_commit_hw_done(struct drm_atomic_state 
*old_state)
  1831  {
  1832          struct drm_crtc *crtc;
  1833          struct drm_crtc_state *old_crtc_state, *new_crtc_state;
  1834          struct drm_crtc_commit *commit;
  1835          int i;
  1836  
  1837          for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, 
new_crtc_state, i) {
  1838                  commit = new_crtc_state->commit;
  1839                  if (!commit)
  1840                          continue;
  1841  
  1842                  /*
  1843                   * copy new_crtc_state->commit to 
old_crtc_state->commit,
  1844                   * it's unsafe to touch new_crtc_state after hw_done,
  1845                   * but we still need to do so in cleanup_done().
  1846                   */
  1847                  if (old_crtc_state->commit)
  1848                          drm_crtc_commit_put(old_crtc_state->commit);
  1849  
> 1850                  old_crtc_state->commit = drm_crtc_commit_get(commit);
  1851  
  1852                  /* backend must have consumed any event by now */
  1853                  WARN_ON(new_crtc_state->event);
  1854                  complete_all(&commit->hw_done);
  1855          }
  1856  }
  1857  EXPORT_SYMBOL(drm_atomic_helper_commit_hw_done);
  1858  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to