Thanks! Learned. :) -----Original Message----- From: Joonas Lahtinen [mailto:[email protected]] Sent: Friday, September 8, 2017 2:54 PM To: Wang, Zhi A <[email protected]>; [email protected]; [email protected] Cc: [email protected]; [email protected]; Widawsky, Benjamin <[email protected]>; Vivi, Rodrigo <[email protected]> Subject: Re: [PATCH v8 1/5] drm/i915: Factor out setup_private_pat()
On Fri, 2017-09-08 at 17:05 +0800, Zhi Wang wrote: > Factor out setup_private_pat() for introducing the following patches. > > Cc: Ben Widawsky <[email protected]> > Cc: Rodrigo Vivi <[email protected]> > Cc: Chris Wilson <[email protected]> > Cc: Joonas Lahtinen <[email protected]> > Reviewed-by: Chris Wilson <[email protected]> v7 > Signed-off-by: Zhi Wang <[email protected]> Keep this in chronological order when you add things, so R-b after S-o- b. Only add the version after R-b *if* the review might have been invalidated due to some changes, in this case there are no changes and no changelog, so you can keep the R-b. If there was substantial enough changes, changelog would be added and #v7 added to previous reviews to indicate they do not apply to latest changes. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
