> -----Original Message----- > From: Intel-gfx [mailto:[email protected]] On Behalf Of > Vidya Srinivas > Sent: Tuesday, September 5, 2017 3:15 PM > To: [email protected] > Cc: Srinivas, Vidya <[email protected]> > Subject: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready > before shutdown command" > > From: Uma Shankar <[email protected]> > > This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282. > > Disable device ready before shutdown command was added previously to > avoid a split screen issue seen on dual link DSI panels. As of now, dual link > is > not supported and will need some rework in the upstream code. For single > link DSI panels, the change is not required. This will cause failure in > sending > SHUTDOWN packet during disable. Hence reverting the change. Will handle > the change as part of dual link enabling in upstream.
Already there are lot of changes wrt to DSI dual link inside intel_dsi.c. Can't we keep this change as well under the condition if (dual_link && Broxton)?? Might help to fetch dual link changes in future instead of losing it. Regards, Madhav > > Signed-off-by: Uma Shankar <[email protected]> > Signed-off-by: Vidya Srinivas <[email protected]> > --- > drivers/gpu/drm/i915/intel_dsi.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c > b/drivers/gpu/drm/i915/intel_dsi.c > index 2a0f5d3..fc25d7d 100644 > --- a/drivers/gpu/drm/i915/intel_dsi.c > +++ b/drivers/gpu/drm/i915/intel_dsi.c > @@ -892,8 +892,6 @@ static void intel_dsi_disable(struct intel_encoder > *encoder, > const struct intel_crtc_state *old_crtc_state, > const struct drm_connector_state > *old_conn_state) { > - struct drm_device *dev = encoder->base.dev; > - struct drm_i915_private *dev_priv = dev->dev_private; > struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base); > enum port port; > > @@ -903,15 +901,6 @@ static void intel_dsi_disable(struct intel_encoder > *encoder, > intel_panel_disable_backlight(old_conn_state); > > /* > - * Disable Device ready before the port shutdown in order > - * to avoid split screen > - */ > - if (IS_BROXTON(dev_priv)) { > - for_each_dsi_port(port, intel_dsi->ports) > - I915_WRITE(MIPI_DEVICE_READY(port), 0); > - } > - > - /* > * According to the spec we should send SHUTDOWN before > * MIPI_SEQ_DISPLAY_OFF only for v3+ VBTs, but field testing > * has shown that the v3 sequence works for v2 VBTs too > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
