Joonas Lahtinen <[email protected]> writes:

> On Tue, 2017-10-10 at 14:48 +0300, Mika Kuoppala wrote:
>> There is function to tell how many ports we have, so use it.
>> We still have direct relationship with array size and port count,
>> so no harm was done.
>> 
>> Fixes: 76e70087d360 ("drm/i915: Make execlist port count variable")
>> Cc: Mika Kuoppala <[email protected]>
>> Cc: Chris Wilson <[email protected]>
>> Signed-off-by: Mika Kuoppala <[email protected]>
>
> <SNIP>
>
>> +++ b/drivers/gpu/drm/i915/i915_guc_submission.c
>> @@ -500,7 +500,7 @@ static void i915_guc_submit(struct intel_engine_cs 
>> *engine)
>>      const unsigned int engine_id = engine->id;
>>      unsigned int n;
>>  
>> -    for (n = 0; n < ARRAY_SIZE(execlists->port); n++) {
>> +    for (n = 0; n < execlists_num_ports(execlists); n++) {
>
> For a while I was looking this delta in reverse and could not figure it
> out.
>
> Reviewed-by: Joonas Lahtinen <[email protected]>
>

I think I messed atleast on one of these missing on the countless
rebases.

Thanks for reviews. Pushed.
-Mika
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to