Hi Hans, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/drm-fbdev-Panel-orientation-connector-property-support/20171128-225025 config: x86_64-randconfig-x012-201748 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/gpu/drm/i915/intel_dsi.c: In function 'intel_dsi_get_panel_orientation': drivers/gpu/drm/i915/intel_dsi.c:1672:21: error: storage size of 'plane' isn't known enum i9xx_plane_id plane; ^~~~~ >> drivers/gpu/drm/i915/intel_dsi.c:1672:21: error: unused variable 'plane' >> [-Werror=unused-variable] cc1: all warnings being treated as errors vim +/plane +1672 drivers/gpu/drm/i915/intel_dsi.c 1667 1668 static int intel_dsi_get_panel_orientation(struct intel_connector *connector) 1669 { 1670 struct drm_i915_private *dev_priv = to_i915(connector->base.dev); 1671 int orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL; > 1672 enum i9xx_plane_id plane; 1673 u32 val; 1674 1675 if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) { 1676 if (connector->encoder->crtc_mask == BIT(PIPE_B)) 1677 plane = PLANE_B; 1678 else 1679 plane = PLANE_A; 1680 1681 val = I915_READ(DSPCNTR(plane)); 1682 if (val & DISPPLANE_ROTATE_180) 1683 orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP; 1684 } 1685 1686 return orientation; 1687 } 1688 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
