On Wednesday 14 February 2018 08:06 PM, Chris Wilson wrote:
Quoting Ramalingam C (2018-02-14 14:13:40)
For upcoming implementation of HDCP2.2 in I915, all variable required
for HDCP2.2 are defined.

This includes a translation layer called hdcp2_shim for encoder
specific HDCP2.2 spec deviations.

Signed-off-by: Ramalingam C <ramalinga...@intel.com>
---
  drivers/gpu/drm/i915/i915_drv.h  |  5 +++
  drivers/gpu/drm/i915/intel_drv.h | 91 ++++++++++++++++++++++++++++++++++++++++
  2 files changed, 96 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 3f8d824dc313..09d31db90a38 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -44,6 +44,7 @@
  #include <linux/pm_qos.h>
  #include <linux/reservation.h>
  #include <linux/shmem_fs.h>
+#include <linux/mei_hdcp.h>
Why? You only want a forward decl for struct mei_cl_device.

  #include <drm/drmP.h>
  #include <drm/intel-gtt.h>
@@ -2365,6 +2366,10 @@ struct drm_i915_private {
struct i915_pmu pmu; + /* Mei interface handle */
+       struct mei_cl_device *mei_cldev;
+       int mei_ref_cnt;
This isn't used in this patch, which makes it very hard to verify. At
first glance, I don't buy that mei_ref_cnt is properly protected.
-Chris
We need to protect the count. Thanks for finding the miss. will fix it.
thanks
--Ram

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to