On Wed, Feb 21, 2018 at 12:04:43AM +0000, Mustaffa, Mustamin B wrote: > Hi Ville, > > Can you point out what makes you says the git diff is broken?
Because your diff shows like the change was in vlv_ fucntion, not on bxt_ one... If it wasn't by the TODO comment block I'd reply that your code was wrong. But I opened the code to check myself that TODO was only on bxt function and that it was only your diff that was broken.... > > Best regard > > Mustamin > > > -----Original Message----- > From: Ville Syrjälä [mailto:[email protected]] > Sent: Tuesday, February 20, 2018 10:26 PM > To: Mustaffa, Mustamin B <[email protected]> > Cc: [email protected] > Subject: Re: [Intel-gfx] [V4] drm/i915: Enable VBT based BL control for DP > > On Tue, Feb 20, 2018 at 05:42:59PM +0800, Mustamin B Mustaffa wrote: > > Currently, BXT_PP is hardcoded with value '0'. > > It practically disabled eDP backlight on MRB (BXT) platform. > > > > This patch will tell which BXT_PP registers (there are two set of > > PP_CONTROL in the spec) to be used as defined in VBT (Video Bios > > Timing > > table) and this will enabled eDP backlight controller on MRB (BXT) > > platform. > > > > v2: > > - Remove unnecessary information in commit message. > > - Assign vbt.backlight.controller to a backlight_controller variable and > > return the variable value. > > v3: > > - Rebased to latest code base. > > - updated commit title. > > V4: > > - Use sanitized panel backlight controller instead of vbt backlight > > controller > > > > Signed-off-by: Mustamin B Mustaffa <[email protected]> > > --- > > drivers/gpu/drm/i915/intel_dp.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > b/drivers/gpu/drm/i915/intel_dp.c index 1868f73..f9b922d 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -655,18 +655,15 @@ static enum pipe vlv_find_free_pps(struct > > drm_i915_private *dev_priv) > > Your git diff is clearly broken. This makes patch review harder than it has > to be. Please consider updating to a non-broken version. > > > { > > struct drm_i915_private *dev_priv = > > to_i915(intel_dp_to_dev(intel_dp)); > > > > + int backlight_controller = > > +intel_dp->attached_connector->panel.backlight.controller; > > + > > lockdep_assert_held(&dev_priv->pps_mutex); > > > > /* We should never land here with regular DP ports */ > > WARN_ON(!intel_dp_is_edp(intel_dp)); > > > > - /* > > - * TODO: BXT has 2 PPS instances. The correct port->PPS instance > > - * mapping needs to be retrieved from VBT, for now just hard-code to > > - * use instance #0 always. > > - */ > > if (!intel_dp->pps_reset) > > - return 0; > > + return backlight_controller; > > > > intel_dp->pps_reset = false; > > > > @@ -676,7 +673,7 @@ static enum pipe vlv_find_free_pps(struct > > drm_i915_private *dev_priv) > > */ > > intel_dp_init_panel_power_sequencer_registers(intel_dp, false); > > > > - return 0; > > + return backlight_controller; > > } > > > > typedef bool (*vlv_pipe_check)(struct drm_i915_private *dev_priv, > > -- > > 1.9.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > [email protected] > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel OTC > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
