On Mon, Apr 09, 2018 at 12:48:15PM +0300, Jani Nikula wrote: > On Fri, 23 Mar 2018, Timo Aaltonen <[email protected]> wrote: > > On 30.01.2018 00:12, Rodrigo Vivi wrote: > >> On Mon, Jan 29, 2018 at 05:42:53AM +0000, Kai Heng Feng wrote: > >>> > >>>> On 26 Jan 2018, at 6:25 AM, Rodrigo Vivi <[email protected]> wrote: > >>>> > >>>> If the table result is out of bounds on the array map > >>>> there is something really wrong with VBT pin so we don't > >>>> return that vbt_pin, but only return 0 instead. > >>>> > >>>> This basically reverts commit 'a8e6f3888b05 ("drm/i915/cnp: > >>>> Ignore VBT request for know invalid DDC pin.")' > >>>> > >>>> Also this properly fixes commit 9c3b2689d01f ("drm/i915/cnl: > >>>> Map VBT DDC Pin to BSpec DDC Pin.") > >>>> > >>>> v2: Do in a way that we don't break other platforms. (Jani) > >>>> > >>>> v3: Keep debug message (Jani) > >>>> > >>>> v4: Don't mess with 0 mapping was noticed by Jani and > >>>> addressed with a simple solution suggested by Lucas > >>>> that makes this even simpler. > >>>> > >>>> Fixes: a8e6f3888b05 ("drm/i915/cnp: Ignore VBT request for know invalid > >>>> DDC pin.") > >>>> Fixes: 9c3b2689d01f ("drm/i915/cnl: Map VBT DDC Pin to BSpec DDC Pin.") > >>>> Cc: Radhakrishna Sripada <[email protected]> > >>>> Cc: Jani Nikula <[email protected]> > >>>> Cc: Kai Heng Feng <[email protected]> > >>>> Cc: Lucas De Marchi <[email protected]> > >>>> Suggested-by: Lucas De Marchi <[email protected]> > >>>> Signed-off-by: Rodrigo Vivi <[email protected]> > >>> > >>> Tested-by: Kai-Heng Feng <[email protected]> > >> > >> merged. thanks for suggestions, reviews, tests and patience ;) > > > > Shouldn't this and > > > > drm/i915/cnp: Ignore VBT request for know invalid DDC pin. > > > > be cc:stable? Though they aren't even in 4.16 yet. > > Apologies for nobody replying. The commits are in v4.16, and I've made a > stable backport request for v4.15.
Ops, my bad. I'm sorry... I had missed those. Thank you very much Jani. > > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
