Instead of using a backchannel if some dpcd read failed we can show that directly on debugfs output.
We are not returning an error because we might still want to know if sub-sequent reads works, but we shouldn't need to check 2 places to see why reg is not on the list. Cc: Jani Nikula <[email protected]> Cc: Dhinakaran Pandiyan <[email protected]> Signed-off-by: Rodrigo Vivi <[email protected]> --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 59dc0610ea44..5d8da4e8c444 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -4846,8 +4846,8 @@ static int i915_dpcd_show(struct seq_file *m, void *data) err = drm_dp_dpcd_read(&intel_dp->aux, b->offset, buf, size); if (err <= 0) { - DRM_ERROR("dpcd read (%zu bytes at %u) failed (%zd)\n", - size, b->offset, err); + seq_printf(m, "dpcd read (%zu bytes at %u) failed (%zd)\n", + size, b->offset, err); continue; } -- 2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
