On Tue, Sep 04, 2018 at 01:49:56PM +0100, Chris Wilson wrote: > Make sure we do flush out the previous spinner and delay signaling > transition completion until we do. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102250 > Signed-off-by: Chris Wilson <[email protected]> > Cc: Katarzyna Dec <[email protected]> > --- > tests/pm_rps.c | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/tests/pm_rps.c b/tests/pm_rps.c > index 84e71fa8a..23b33f41b 100644 > --- a/tests/pm_rps.c > +++ b/tests/pm_rps.c > @@ -218,6 +218,7 @@ static void load_helper_set_load(enum load load) > > static void load_helper_run(enum load load) > { > + bool dummy; > int link[2]; > > /* > @@ -233,13 +234,14 @@ static void load_helper_run(enum load load) > > lh.exit = false; > lh.load = load; > - lh.signal = false; > + lh.signal = true; > > pipe(link); > lh.link = link[1]; > > igt_fork_helper(&lh.igt_proc) { > igt_spin_t *spin[2] = {}; > + bool prev_load; > uint32_t handle; > > signal(SIGUSR1, load_helper_signal_handler); > @@ -247,10 +249,14 @@ static void load_helper_run(enum load load) > > igt_debug("Applying %s load...\n", lh.load ? "high" : "low"); > > + prev_load = lh.load == HIGH; I would add parenthesis to improve clarity: prev_load = (lh.load == HIGH);
Despite this: Reviewed-by: Katarzyna Dec <[email protected]> _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
