On Fri, Sep 14, 2018 at 07:18:46AM -0700, José Roberto de Souza wrote: > IPC was only added in SKL+(actually we don't even enable for SKL due > WA) so without this change, driver was writing to a reserved bit. > > Also removing the uncessary dev_priv->ipc_enabled = false; as now > gens without IPC will not have IPC enabled. > > v2(Rodrigo): > - moved the new handling of WA #0477 to the next patch > > Cc: Rodrigo Vivi <[email protected]> > Signed-off-by: José Roberto de Souza <[email protected]>
Reviewed-by: Rodrigo Vivi <[email protected]> > --- > drivers/gpu/drm/i915/intel_pm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 1db9b8328275..e2ca04534e23 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -6117,6 +6117,9 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv) > { > u32 val; > > + if (!HAS_IPC(dev_priv)) > + return; > + > /* Display WA #0477 WaDisableIPC: skl */ > if (IS_SKYLAKE(dev_priv)) > dev_priv->ipc_enabled = false; > @@ -6138,7 +6141,6 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv) > > void intel_init_ipc(struct drm_i915_private *dev_priv) > { > - dev_priv->ipc_enabled = false; > if (!HAS_IPC(dev_priv)) > return; > > -- > 2.19.0 > _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
