On Thu, Oct 18, 2018 at 01:51:26PM +0200, Maarten Lankhorst wrote: > New version, with a lot of reworking to incorporate all the feedback. > > We currently don't set the plane input CSC correctly, so colors are a > bit off. As a result I can't verify for 100% we program the chroma > upsampler correctly, but I still want to put out this series for review.
I didn't spot a change to skl_plane_has_planar() in this series. Did that fall off during a rebase or was it never there? Did you test this version locally? Mainly wondering if we have a bug in the core that it lets unsupported pixel formats through... > > Maarten Lankhorst (8): > drm/i915: Fix unsigned overflow when calculating total data rate > drm/i915/gen11: Enable 6 sprites on gen11 > drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v4. > drm/i915/gen11: Handle watermarks correctly for separate Y/UV planes, > v2. > drm/i915/gen11: Program the scalers correctly for planar formats, v3. > drm/i915/gen11: Program the chroma upsampler for HDR planes. > drm/i915/gen11: Program the Y and UV plane for planar mode correctly, > v3. > drm/i915/gen11: Expose planar format support on gen11. > > drivers/gpu/drm/i915/i915_reg.h | 27 +- > drivers/gpu/drm/i915/intel_atomic.c | 16 +- > drivers/gpu/drm/i915/intel_atomic_plane.c | 74 ++++- > drivers/gpu/drm/i915/intel_device_info.c | 22 +- > drivers/gpu/drm/i915/intel_display.c | 120 ++++++-- > drivers/gpu/drm/i915/intel_display.h | 3 + > drivers/gpu/drm/i915/intel_drv.h | 61 ++++ > drivers/gpu/drm/i915/intel_pm.c | 360 ++++++++++++++-------- > drivers/gpu/drm/i915/intel_sprite.c | 72 ++++- > 9 files changed, 575 insertions(+), 180 deletions(-) > > -- > 2.19.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
