== Series Details ==
Series: series starting with [v3,1/3] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52459/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f5816a94faad drm/i915/icl: replace check for combo phy
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__port' - possible
side-effects?
#23: FILE: drivers/gpu/drm/i915/intel_combo_phy.c:8:
+#define for_each_combo_port(__dev_priv, __port) \
+ for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++) \
+ for_each_if(intel_port_is_combophy(__dev_priv, __port))
total: 0 errors, 0 warnings, 1 checks, 26 lines checked
a96e90922991 drm/i915/icl: reverse uninit order
-:26: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__port' - possible
side-effects?
#26: FILE: drivers/gpu/drm/i915/intel_combo_phy.c:12:
+#define for_each_combo_port_reverse(__dev_priv, __port) \
+ for ((__port) = I915_MAX_PORTS; (__port)-- > PORT_A;) \
+ for_each_if(intel_port_is_combophy(__dev_priv, __port))
total: 0 errors, 0 warnings, 1 checks, 18 lines checked
49663aa28220 drm/i195: spell out reverse on for_each macros
-:20: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements
should be enclosed in a do - while loop
#20: FILE: drivers/gpu/drm/i915/intel_display.h:371:
+#define for_each_power_well_reverse(__dev_priv, __power_well)
\
for ((__power_well) = (__dev_priv)->power_domains.power_wells +
\
(__dev_priv)->power_domains.power_well_count - 1;
\
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0;
\
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible
side-effects?
#20: FILE: drivers/gpu/drm/i915/intel_display.h:371:
+#define for_each_power_well_reverse(__dev_priv, __power_well)
\
for ((__power_well) = (__dev_priv)->power_domains.power_wells +
\
(__dev_priv)->power_domains.power_well_count - 1;
\
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0;
\
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible
side-effects?
#20: FILE: drivers/gpu/drm/i915/intel_display.h:371:
+#define for_each_power_well_reverse(__dev_priv, __power_well)
\
for ((__power_well) = (__dev_priv)->power_domains.power_wells +
\
(__dev_priv)->power_domains.power_well_count - 1;
\
(__power_well) - (__dev_priv)->power_domains.power_wells >= 0;
\
-:30: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#30: FILE: drivers/gpu/drm/i915/intel_display.h:381:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well,
__domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well)
\
for_each_if((__power_well)->desc->domains & (__domain_mask))
-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible
side-effects?
#30: FILE: drivers/gpu/drm/i915/intel_display.h:381:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well,
__domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well)
\
for_each_if((__power_well)->desc->domains & (__domain_mask))
total: 2 errors, 0 warnings, 3 checks, 34 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
