First of all, I managed to go and get quite sick, so please bare with any slowness.
On Thu, Jan 31, 2013 at 02:40:20AM +0000, Cheah, Vincent Beng Keat wrote: > Hey Ben, > > For your quick dump mechanism yours, there are also some consideration that > you might have left out - overlapping IRQ and some other registers that have > the same offset for both render and display (since base_interrupt, base_power > doesn’t include other VLV IRQ/Power register sets not part of current base > tables. On top of that there are also some registers that are still missing > in accordance bspecs. Are you going to add that in upon pushing it to the > master branch? If not, then I have volunteered to help you get all the > registers ready setup for you. > > The work I did thus far was very much just hacking something to work to submit RFC patches and enable us for power-on. Depending on my health, I plan to rebase what was there, maybe add the appropriate automake cleanups (if any are needed) and get it upstream. I also realize Jesse added the DPIO support which I may need to cleanup or review or whatever. I don't understand your concern, so maybe ask me again once the current stuff is upstreamed? As a side note, I never pushed Jesse's additions, which I've just done. http://cgit.freedesktop.org/~bwidawsk/intel-gpu-tools/log/?h=dump_util2 > I don’t think there is any other patches required on our side. Oh yes before > I forget, there is some BAR memory mapping fixes for VLV in order for it to > work - intel_gtt.c > > for (f = 0; flag[f] != 0; f++) { > if (IS_GEN3(devid)) { > /* 915/945 chips has GTT range in bar 3 */ > if (pci_device_map_range(pci_dev, > > pci_dev->regions[3].base_addr, > > pci_dev->regions[3].size, > flag[f], > (void **)>t) == 0) > break; > } else { > int offset; > if (IS_G4X(devid) || IS_GEN5(devid) || > IS_VALLEYVIEW(devid)) > offset = MB(2); > else > offset = KB(512); > if (pci_device_map_range(pci_dev, > > pci_dev->regions[0].base_addr + offset, > offset, > flag[f], > (void **)>t) == 0) > break; > } > } > > Can you please send this again as a unified diff (also a new email thread would be appropriate). > In between, I'm also in the process of creating a personal repo to keep our > own internal bad version of intel_reg_read / write as for now so we can carry > on with our internal testing and providing a quick solution temporary for our > customer to read/write MMIO regs. I have a problem, creating an account in > people.freedesktop.org. The link below simply does not provide me much > information. By the way, I did apply membership in Xorg foundation based to > some other link where I came across, but I don't seems to be able help > neither. Am I missing anything? > > (http://www.freedesktop.org/wiki/Infrastructure/git/RepositoryAdmin) > > Thanks. > > ...vincent The admins are slow. They're all part-time or less. I'd recommending just using the internal git services for this kind of stuff. [snip] -- Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
