On Wed, Dec 19, 2018 at 01:59:12PM +0530, [email protected] wrote:
> From: P Raviraj Sitaram <[email protected]>
> 
> framebuffer for NV12 requires the pitch to the multiplier of 4, instead
> of the width. This patch corrects it.
> 
> For instance, a 480p video, whose width and pitch are 854 and 896
> respectively, is excluded for NV12 plane so far.
> 
> Changes since v1:
>     - Removed check for NV12 buffer dimensions since additional checks
>       are done for viewport size in intel_sprite.c
> 
> Signed-off-by: Dongseong Hwang <[email protected]>
> Signed-off-by: P Raviraj Sitaram <[email protected]>
> Cc: Chandra Konduru <[email protected]>
> Cc: Vidya Srinivas <[email protected]>
> Cc: Ville Syrjälä <[email protected]>
> Cc: Juha-Pekka Heikkila <[email protected]>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c 
> b/drivers/gpu/drm/i915/intel_display.c
> index 3b7094822aa9..fa349182d0da 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14597,14 +14597,6 @@ static int intel_framebuffer_init(struct 
> intel_framebuffer *intel_fb,
>  
>       drm_helper_mode_fill_fb_struct(&dev_priv->drm, fb, mode_cmd);
>  
> -     if (fb->format->format == DRM_FORMAT_NV12 &&
> -         (fb->width < SKL_MIN_YUV_420_SRC_W ||
> -          fb->height < SKL_MIN_YUV_420_SRC_H ||
> -          (fb->width % 4) != 0 || (fb->height % 4) != 0)) {
> -             DRM_DEBUG_KMS("src dimensions not correct for NV12\n");
> -             goto err;
> -     }

Looks correct to me.

Thanks for the patch, pushed to dinq.

> -
>       for (i = 0; i < fb->format->num_planes; i++) {
>               u32 stride_alignment;
>  
> -- 
> 2.7.4

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to