On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza wrote: > drm_atomic_commit() call chain already takes care of adding > connectors and planes, so lets no add then manually if not changing > their states.
The specific callgraph would make review easier. > > Cc: Ville Syrjälä <[email protected]> > Cc: Lyude Paul <[email protected]> > Signed-off-by: José Roberto de Souza <[email protected]> > --- > drivers/gpu/drm/i915/intel_ddi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > b/drivers/gpu/drm/i915/intel_ddi.c > index 34dd5823398a..c22ddde2dfc1 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc *crtc, > > crtc_state->mode_changed = true; > > - ret = drm_atomic_add_affected_connectors(state, crtc); > - if (ret) > - goto out; > - > - ret = drm_atomic_add_affected_planes(state, crtc); > - if (ret) > - goto out; > - > ret = drm_atomic_commit(state); > out: > drm_atomic_state_put(state); > -- > 2.21.0 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
