All of this checks are redudant and can be removed as the if bellow
already takes care when there is no changes in the state.

Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com>
Signed-off-by: José Roberto de Souza <jose.so...@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 73453d89a841..d3e3996551c6 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -878,15 +878,11 @@ void intel_psr_update(struct intel_dp *intel_dp,
        if (enable == psr->enabled && psr2_enable == psr->psr2_enabled)
                goto unlock;
 
-       if (psr->enabled) {
-               if (!enable || psr2_enable != psr->psr2_enabled)
-                       intel_psr_disable_locked(intel_dp);
-       }
+       if (psr->enabled)
+               intel_psr_disable_locked(intel_dp);
 
-       if (enable) {
-               if (!psr->enabled || psr2_enable != psr->psr2_enabled)
-                       intel_psr_enable_locked(dev_priv, crtc_state);
-       }
+       if (enable)
+               intel_psr_enable_locked(dev_priv, crtc_state);
 
 unlock:
        mutex_unlock(&dev_priv->psr.lock);
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to