On Wed, Mar 20, 2019 at 04:01:51PM +0000, Chris Wilson wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110212
> Fixes: 8ae86621d6ff ("lib/igt_device: Move intel_get_pci_device under 
> igt_device")
> Signed-off-by: Chris Wilson <[email protected]>
> Cc: Michał Winiarski <[email protected]>
> ---
>  tests/i915/gem_shrink.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c
> index 73b6be725..51d1343ba 100644
> --- a/tests/i915/gem_shrink.c
> +++ b/tests/i915/gem_shrink.c
> @@ -403,7 +403,12 @@ igt_main
>               unsigned int engine;
>               int fd;
>  
> -             /* Spawn enough processes to use all memory, but each only
> +             fd = drm_open_driver(DRIVER_INTEL);
> +             igt_require_gem(fd);
> +
> +

Bonus newline?

Reviewed-by: Ville Syrjälä <[email protected]>

> +             /*
> +              * Spawn enough processes to use all memory, but each only
>                * uses half the available mappable aperture ~128MiB.
>                * Individually the processes would be ok, but en masse
>                * we expect the shrinker to start purging objects,
> @@ -418,9 +423,6 @@ igt_main
>               intel_require_memory(num_processes, alloc_size,
>                                    CHECK_SWAP | CHECK_RAM);
>  
> -             fd = drm_open_driver(DRIVER_INTEL);
> -             igt_require_gem(fd);
> -
>               nengine = 0;
>               for_each_engine(fd, engine)
>                       engines[nengine++] = engine;
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to