> -----Original Message----- > From: Deak, Imre > Sent: Wednesday, March 20, 2019 4:38 PM > To: Kulkarni, Vandita <[email protected]> > Cc: [email protected]; Nikula, Jani <[email protected]> > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl/dsi: Fix port disable > sequence > > On Wed, Mar 20, 2019 at 03:38:59PM +0530, Vandita Kulkarni wrote: > > Re-enable clock gating of DDI clocks. > > > > Fixes: 1026bea00381 (drm/i915/icl: Ungate DSI clocks) > > Signed-off-by: Vandita Kulkarni <[email protected]> > > --- > > drivers/gpu/drm/i915/icl_dsi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/icl_dsi.c > > b/drivers/gpu/drm/i915/icl_dsi.c index f02504d..716be38 100644 > > --- a/drivers/gpu/drm/i915/icl_dsi.c > > +++ b/drivers/gpu/drm/i915/icl_dsi.c > > @@ -1125,7 +1125,7 @@ static void gen11_dsi_disable_port(struct > intel_encoder *encoder) > > DRM_ERROR("DDI port:%c buffer not idle\n", > > port_name(port)); > > } > > - gen11_dsi_ungate_clocks(encoder); > > + gen11_dsi_gate_clocks(encoder); > > This also requires updating icl_sanitize_encoder_pll_mapping().
Thank you. Will send the fix in v2. -Vandita > Currently it assumes that the DDI clock needs to be ungated if the > corresponding > DSI port is disabled and gated if the port is enabled. > > The changes in this patchset mean that the DDI clock should be gated for DSI > ports regardless of whether the port is enabled or not. > > > } > > > > static void gen11_dsi_disable_io_power(struct intel_encoder *encoder) > > -- > > 1.9.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > [email protected] > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
