On Fri, Mar 01, 2013 at 01:14:17PM -0800, Jesse Barnes wrote:
> For current usage, not needed.
>
> Signed-off-by: Vijay Purushothaman <[email protected]>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 7de8cec..b8f5a17 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4211,7 +4211,9 @@ void intel_init_pm(struct drm_device *dev)
> } else
> dev_priv->display.update_wm = NULL;
> } else if (IS_VALLEYVIEW(dev)) {
> - dev_priv->display.update_wm = valleyview_update_wm;
> +// dev_priv->display.update_wm = valleyview_update_wm;
> + dev_priv->display.update_wm = NULL;
> +// dev_priv->display.update_sprite_wm =
> valleyview_update_sprite_wm;
Either kill this all (it's kzalloced so no need for NULL assignments) or
add a giant comment explaining what's going on. Adding commented-out code
without comment is strange ...
-Daniel
> dev_priv->display.init_clock_gating =
> valleyview_init_clock_gating;
> } else if (IS_PINEVIEW(dev)) {
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
