On Tue, 5 Mar 2013 13:56:31 +0100 Daniel Vetter <[email protected]> wrote:
> On Fri, Mar 1, 2013 at 11:08 PM, Jesse Barnes <[email protected]> > wrote: > > From: Pallavi G <[email protected]> > > > > > > For high res modes m n p calculation is fixed for VLV platform. > > > > Signed-off-by: Vijay Purushothaman <[email protected]> > > Signed-off-by: Pallavi G <[email protected]> > > Signed-off-by: Yogesh M <[email protected]> > > Signed-off-by: Gajanan Bhat <[email protected]> > > I'll throw a few more nits on top: > - From: should usually also be the first sob line or maybe a quick > comment about the origins of the patch. > - This function indents a few too many levels by any standard. > - I'd prefer if we switch dp to just select the desired m/n/p values > for a given clock like on all other platforms. See the vlv FIXME in > https://patchwork.kernel.org/patch/2173841/ Yeah, seems reasonable... lemme see about fixing that up along with what Ville suggested. -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
