== Series Details ==
Series: Revert "drm/i915: Expand subslice mask"
URL : https://patchwork.freedesktop.org/series/61293/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2ec02f472bf8 Revert "drm/i915: Expand subslice mask"
-:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#20:
<3>[ 9.426327] intel_sseu_get_subslices:46 GEM_BUG_ON(slice >=
sseu->max_slices)
-:88: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 1e40d4aea57b ("drm/i915/cnl:
Implement WaProgramMgsrForCorrectSliceSpecificMmioReads")'
#88:
References: 1e40d4aea57b ("drm/i915/cnl: Implement
WaProgramMgsrForCorrectSliceSpecificMmioReads")
-:180: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible
side-effects?
#180: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:555:
+#define instdone_slice_mask(dev_priv__) \
+ (IS_GEN(dev_priv__, 7) ? \
+ 1 : RUNTIME_INFO(dev_priv__)->sseu.slice_mask)
-:184: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible
side-effects?
#184: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:559:
+#define instdone_subslice_mask(dev_priv__) \
+ (IS_GEN(dev_priv__, 7) ? \
+ 1 : RUNTIME_INFO(dev_priv__)->sseu.subslice_mask[0])
-:188: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible
side-effects?
#188: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:563:
+#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \
+ for ((slice__) = 0, (subslice__) = 0; \
+ (slice__) < I915_MAX_SLICES; \
+ (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ?
(subslice__) + 1 : 0, \
+ (slice__) += ((subslice__) == 0)) \
+ for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) &&
\
+ (BIT(subslice__) &
instdone_subslice_mask(dev_priv__)))
-:188: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice__' - possible
side-effects?
#188: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:563:
+#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \
+ for ((slice__) = 0, (subslice__) = 0; \
+ (slice__) < I915_MAX_SLICES; \
+ (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ?
(subslice__) + 1 : 0, \
+ (slice__) += ((subslice__) == 0)) \
+ for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) &&
\
+ (BIT(subslice__) &
instdone_subslice_mask(dev_priv__)))
-:188: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible
side-effects?
#188: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:563:
+#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \
+ for ((slice__) = 0, (subslice__) = 0; \
+ (slice__) < I915_MAX_SLICES; \
+ (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ?
(subslice__) + 1 : 0, \
+ (slice__) += ((subslice__) == 0)) \
+ for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) &&
\
+ (BIT(subslice__) &
instdone_subslice_mask(dev_priv__)))
total: 1 errors, 1 warnings, 5 checks, 679 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
