Quoting Chris Wilson (2019-05-31 19:11:29)
> As the fence registers are not part of the engine powerwells, we do not
> need to fiddle with forcewake in order to update a fence. Avoid using
> the heavyweight debug checking normal mmio writes as the checking
> dominates the selftest runtime and is superfluous!
> 
> In the process, retire the I915_WRITE() implicit macro with the new
> intel_uncore_write interface.
> 
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>

I think 'uncore' isn't too long to write fully. Assuming I
noticed all the code changes from the renames, this is:

Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>

I still can't but think of the _fw prefixed functions as something that
specifically _forcewake{_device_up}, but maybe it's just me who is
confused.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to