On Mon, 24 Jun 2019, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On Mon, 24 Jun 2019 at 09:21, Daniel Vetter <dan...@ffwll.ch> wrote: > >> > drm_legacy.h >> > - needs drm_map_type and drm_map_flags. Seems legit. >> >> enum in uapi, sweet (never do this, it's not portable across compilers, >> #defines all the way). > > Don't look too closely then > $ git grep enum -- include/uapi/drm/ | wc -l > 96 > > A handful of those are legacy stuff, yet quite a few are not :-\
Enums are just fine for *values* as long as they're not used as types in struct members or function parameters or return types, right? So we do have some we've screwed up, but it's not nearly as bad as the git grep above would lead you to believe. The ones in question are used in struct drm_map which is used in DRM_IOCTL_GET_MAP, DRM_IOCTL_ADD_MAP, and DRM_IOCTL_RM_MAP. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
