On Mon, Apr 29, 2013 at 01:02:52PM +0300, Jani Nikula wrote: > Stop calling intel_opregion_enable_asle() and consequently > intel_enable_asle() on opregion init. It should not be necessary for > these reasons: > > 1) On PCH split platforms, it only enables GSE interrupt, which is > enabled in irq postinstall anyway. Moreover, the irq enable uses the > wrong bit on IVB+. > > 2) On gen 2, it would enable a reserved pipestat bit. If there were gen > 2 systems with opregion asle support, that is. And the gen 2 irq > handler won't handle it anyway. > > 3) On gen 3-4, the irq postinstall will call > intel_opregion_enable_asle() to enable the pipestat. > > In short, move the asle irq/pipestat enable responsibility to irq > postinstall, which already happens to be in place. > > This should not cause any functional changes, but only do the one line > change here for easier bisectability, just in case, and leave all the > cleanups this allows to followup patches. > > Signed-off-by: Jani Nikula <[email protected]>
Reviewed-by: Damien Lespiau <[email protected]> -- Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
