Hi Chris, Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc2 next-20191009] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-execlists-Leave-tell-tales-as-to-why-pending-is-bad/20191009-212112 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-defconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/i915/gt/intel_lrc.c: In function 'assert_pending_valid': >> drivers/gpu/drm/i915/gt/intel_lrc.c:716:3: error: implicit declaration of >> function 'GEM_TRACE_ERR'; did you mean 'GEM_TRACE'? >> [-Werror=implicit-function-declaration] GEM_TRACE_ERR("Nothing pending for promotion!\n"); ^~~~~~~~~~~~~ GEM_TRACE cc1: some warnings being treated as errors vim +716 drivers/gpu/drm/i915/gt/intel_lrc.c 705 706 static __maybe_unused bool 707 assert_pending_valid(const struct intel_engine_execlists *execlists, 708 const char *msg) 709 { 710 struct i915_request * const *port, *rq; 711 struct intel_context *ce = NULL; 712 713 trace_ports(execlists, msg, execlists->pending); 714 715 if (!execlists->pending[0]) { > 716 GEM_TRACE_ERR("Nothing pending for promotion!\n"); 717 return false; 718 } 719 720 if (execlists->pending[execlists_num_ports(execlists)]) { 721 GEM_TRACE_ERR("Excess pending[%d] for promotion!\n", 722 execlists_num_ports(execlists)); 723 return false; 724 } 725 726 for (port = execlists->pending; (rq = *port); port++) { 727 if (ce == rq->hw_context) { 728 GEM_TRACE_ERR("Duplicate context in pending[%ld]\n", 729 port - execlists->pending); 730 return false; 731 } 732 733 ce = rq->hw_context; 734 if (i915_request_completed(rq)) 735 continue; 736 737 if (i915_active_is_idle(&ce->active)) { 738 GEM_TRACE_ERR("Inactive context in pending[%ld]\n", 739 port - execlists->pending); 740 return false; 741 } 742 743 if (!i915_vma_is_pinned(ce->state)) { 744 GEM_TRACE_ERR("Unpinned context in pending[%ld]\n", 745 port - execlists->pending); 746 return false; 747 } 748 749 if (!i915_vma_is_pinned(ce->ring->vma)) { 750 GEM_TRACE_ERR("Unpinned ringbuffer in pending[%ld]\n", 751 port - execlists->pending); 752 return false; 753 } 754 } 755 756 return ce; 757 } 758 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
