Chris Wilson <[email protected]> writes:

> For a simulated preemption reset, we don't populate the request and so
> do not fill in the guilty context name.
>
> [   79.991294] i915 0000:00:02.0: GPU HANG: ecode 9:1:e757fefe, in  [0]
>
> Just don't mention the empty string in the logs!
>
> Fixes: 742379c0c400 ("drm/i915: Start chopping up the GPU error capture")
> Signed-off-by: Chris Wilson <[email protected]>
> Cc: Mika Kuoppala <[email protected]>
> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c 
> b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 4c1836f0a991..594341e27a47 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1681,7 +1681,7 @@ static const char *error_msg(struct i915_gpu_coredump 
> *error)
>                       "GPU HANG: ecode %d:%x:%08x",
>                       INTEL_GEN(error->i915), engines,
>                       generate_ecode(first));
> -     if (first) {
> +     if (first && first->context.pid) {

The dmesg line included saved me the trouble of seeing how the context
is primed, so:

Reviewed-by: Mika Kuoppala <[email protected]>

>               /* Just show the first executing process, more is confusing */
>               len += scnprintf(error->error_msg + len,
>                                sizeof(error->error_msg) - len,
> -- 
> 2.25.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to