> -----Original Message----- > From: Jani Nikula <[email protected]> > Sent: Wednesday, February 5, 2020 2:00 PM > To: [email protected] > Cc: Nikula, Jani <[email protected]>; Kulkarni, Vandita > <[email protected]>; Ville Syrjala <[email protected]>; > Lisovskiy, Stanislav <[email protected]> > Subject: [PATCH] drm/i915/mst: fix pipe and vblank enable > > Commit 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to > encoders on DDI platforms") pushed pipe and vblank enable to encoders on DDI > platforms, however it missed the DP MST encoder. Fix it. > > Fixes: 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to encoders > on DDI platforms") > Cc: Vandita Kulkarni <[email protected]> > Cc: Ville Syrjala <[email protected]> > Reported-by: Stanislav Lisovskiy <[email protected]> > Signed-off-by: Jani Nikula <[email protected]>
Looks good to me. Reviewed-by: Vandita Kulkarni <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index b8aee506d595..9cd59141953d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -491,6 +491,12 @@ static void intel_mst_enable_dp(struct intel_encoder > *encoder, > struct intel_dp *intel_dp = &intel_dig_port->dp; > struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > > + drm_WARN_ON(&dev_priv->drm, pipe_config->has_pch_encoder); > + > + intel_enable_pipe(pipe_config); > + > + intel_crtc_vblank_on(pipe_config); > + > DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links); > > if (intel_de_wait_for_set(dev_priv, intel_dp->regs.dp_tp_status, > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
