[Intel-gfx] [PATCH 15/19] drm/i915: Kill last user of intel_context_create_request outside of selftests

[Maarten Lankhorst]

Instead of using intel_context_create_request(), use intel_context_pin()
and i915_create_request directly.

Now all those calls are gone outside of selftests. :)

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 43 ++++++++++++++-------
 1 file changed, 29 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c 
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index ba86511f1ef9..5044b315cd45 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1656,6 +1656,7 @@ static int engine_wa_list_verify(struct intel_context *ce,
        const struct i915_wa *wa;
        struct i915_request *rq;
        struct i915_vma *vma;
+       struct i915_gem_ww_ctx ww;
        unsigned int i;
        u32 *results;
        int err;
@@ -1668,29 +1669,34 @@ static int engine_wa_list_verify(struct intel_context 
*ce,
                return PTR_ERR(vma);
 
        intel_engine_pm_get(ce->engine);
-       rq = intel_context_create_request(ce);
-       intel_engine_pm_put(ce->engine);
+       i915_gem_ww_ctx_init(&ww, false);
+retry:
+       err = i915_gem_object_lock(vma->obj, &ww);
+       if (err == 0)
+               err = intel_context_pin_ww(ce, &ww);
+       if (err)
+               goto err_pm;
+
+       rq = i915_request_create(ce);
        if (IS_ERR(rq)) {
                err = PTR_ERR(rq);
-               goto err_vma;
+               goto err_unpin;
        }
 
-       i915_vma_lock(vma);
        err = i915_request_await_object(rq, vma->obj, true);
        if (err == 0)
                err = i915_vma_move_to_active(vma, rq, EXEC_OBJECT_WRITE);
-       i915_vma_unlock(vma);
-       if (err) {
-               i915_request_add(rq);
-               goto err_vma;
-       }
-
-       err = wa_list_srm(rq, wal, vma);
-       if (err)
-               goto err_vma;
+       if (err == 0)
+               err = wa_list_srm(rq, wal, vma);
 
        i915_request_get(rq);
+       if (err)
+               i915_request_skip(rq, err);
        i915_request_add(rq);
+
+       if (err)
+               goto err_rq;
+
        if (i915_request_wait(rq, 0, HZ / 5) < 0) {
                err = -ETIME;
                goto err_rq;
@@ -1715,7 +1721,16 @@ static int engine_wa_list_verify(struct intel_context 
*ce,
 
 err_rq:
        i915_request_put(rq);
-err_vma:
+err_unpin:
+       intel_context_unpin(ce);
+err_pm:
+       if (err == -EDEADLK) {
+               err = i915_gem_ww_ctx_backoff(&ww);
+               if (!err)
+                       goto retry;
+       }
+       i915_gem_ww_ctx_fini(&ww);
+       intel_engine_pm_put(ce->engine);
        i915_vma_unpin(vma);
        i915_vma_put(vma);
        return err;
-- 
2.25.0.24.g3f081b084b0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx