On Thu, Feb 20, 2020 at 11:20:05AM +0000, Emil Velikov wrote: > On Thu, 7 Nov 2019 at 15:17, Ville Syrjala > <ville.syrj...@linux.intel.com> wrote: > > > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > We have a nice little helper to compute a single LUT entry > > for everything except the 8bpc legacy gamma mode. Let's > > complete the set. > > > At a later stage one could rename this & the 10bit one, moving them to > include/drm/. > There are other drivers doing the same thing... not sure if that's > worth it though.
I'd say no. These are specifically about formatting the LUT entry for the hw register. I don't really see much benefit from sharing code to compute hw register values across totally different hardware, even if the bits happen to match by accident. The only good exception I can think of are cases where said register value comes more or less straight from some cross vendor spec. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
