> -----Original Message-----
> From: Shankar, Uma <[email protected]>
> Sent: Wednesday, April 8, 2020 2:21 PM
> To: Kadiyala, Kishore <[email protected]>; intel-
> [email protected]
> Cc: Ville Syrjala <[email protected]>
> Subject: RE: [PATCH v2] drm/i915: Add Plane color encoding support for
> YCBCR_BT2020
>
>
>
> > -----Original Message-----
> > From: Kadiyala, Kishore <[email protected]>
> > Sent: Wednesday, April 8, 2020 2:18 PM
> > To: [email protected]
> > Cc: Kadiyala, Kishore <[email protected]>; Ville Syrjala
> > <[email protected]>; Shankar, Uma <[email protected]>
> > Subject: [PATCH v2] drm/i915: Add Plane color encoding support for
> > YCBCR_BT2020
> >
> > Currently the plane property doesn't have support for YCBCR_BT2020,
> > which enables the corresponding color conversion mode on plane CSC.
> > This propery setting is confined only to HDR Planes as there is
> > limitation in SDR Planes.
>
> Append that this restriction is for ICL+
>
> >
> > V2: Enabling support for YCBCT_BT2020 for HDR planes on
> > platforms GLK & ICL
> >
> > Cc: Ville Syrjala <[email protected]>
> > Cc: Uma Shankar <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_sprite.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c
> > b/drivers/gpu/drm/i915/display/intel_sprite.c
> > index deda351719db..4c25d90d16ce 100644
> > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > @@ -3031,6 +3031,7 @@ skl_universal_plane_create(struct
> > drm_i915_private *dev_priv,
> > struct intel_plane *plane;
> > enum drm_plane_type plane_type;
> > unsigned int supported_rotations;
> > + unsigned int supported_csc;
> > const u64 *modifiers;
> > const u32 *formats;
> > int num_formats;
> > @@ -3105,9 +3106,14 @@ skl_universal_plane_create(struct
> > drm_i915_private *dev_priv,
> > DRM_MODE_ROTATE_0,
> > supported_rotations);
> >
> > + supported_csc = BIT(DRM_COLOR_YCBCR_BT601) |
> > +BIT(DRM_COLOR_YCBCR_BT709);
> > +
> > + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv) &&
> > + (icl_is_hdr_plane(dev_priv, plane_id)))
>
> Refine this condition to enable for all GLK planes and restrict this only to
> bottom
> 3 HDR planes for ICL. Will be good to mention a comment as well that ICL SDR
> planes have some issues with BT2020 conversion, hence not enabling it on those
> planes for ICL.
>
Sure Uma , will do the changes
> > + supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020);
> > +
> > drm_plane_create_color_properties(&plane->base,
> > - BIT(DRM_COLOR_YCBCR_BT601) |
> > - BIT(DRM_COLOR_YCBCR_BT709),
> > + supported_csc,
>
> Handle the BT2020 format in glk_plane_color_ctl as well for GLK.
>
Ok Uma, will fix
> > BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
> >
> BIT(DRM_COLOR_YCBCR_FULL_RANGE),
> > DRM_COLOR_YCBCR_BT709,
> > --
> > 2.17.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
