Hi Lucas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to drm-tip/drm-tip v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Lucas-De-Marchi/display-ddi-keep-register-indexes-in-a-table/20200625-081557
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a002-20200705 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 
f804bd586ee58199db4cfb2da8e9ef067425900b)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_ddi.c:4900:28: error: format string is 
>> not a string literal (potentially insecure) [-Werror,-Wformat-security]
                            DRM_MODE_ENCODER_TMDS, port_info->name);
                                                   ^~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_ddi.c:4900:28: note: treat the string as 
an argument to avoid this
                            DRM_MODE_ENCODER_TMDS, port_info->name);
                                                   ^
                                                   "%s", 
   1 error generated.

vim +4900 drivers/gpu/drm/i915/display/intel_ddi.c

  4860  
  4861  void intel_ddi_init(struct drm_i915_private *dev_priv,
  4862                      const struct intel_ddi_port_info *port_info)
  4863  {
  4864          enum port port = port_info->port;
  4865          struct intel_digital_port *intel_dig_port;
  4866          struct intel_encoder *encoder;
  4867          bool init_hdmi, init_dp, init_lspcon = false;
  4868  
  4869          init_hdmi = intel_bios_port_supports_dvi(dev_priv, port) ||
  4870                  intel_bios_port_supports_hdmi(dev_priv, port);
  4871          init_dp = intel_bios_port_supports_dp(dev_priv, port);
  4872  
  4873          if (intel_bios_is_lspcon_present(dev_priv, port)) {
  4874                  /*
  4875                   * Lspcon device needs to be driven with DP connector
  4876                   * with special detection sequence. So make sure DP
  4877                   * is initialized before lspcon.
  4878                   */
  4879                  init_dp = true;
  4880                  init_lspcon = true;
  4881                  init_hdmi = false;
  4882                  drm_dbg_kms(&dev_priv->drm, "VBT says port %s has 
lspcon\n",
  4883                              port_info->name);
  4884          }
  4885  
  4886          if (!init_dp && !init_hdmi) {
  4887                  drm_dbg_kms(&dev_priv->drm,
  4888                              "VBT says port %s is not DVI/HDMI/DP 
compatible, respect it\n",
  4889                              port_info->name);
  4890                  return;
  4891          }
  4892  
  4893          intel_dig_port = kzalloc(sizeof(*intel_dig_port), GFP_KERNEL);
  4894          if (!intel_dig_port)
  4895                  return;
  4896  
  4897          encoder = &intel_dig_port->base;
  4898  
  4899          drm_encoder_init(&dev_priv->drm, &encoder->base, 
&intel_ddi_funcs,
> 4900                           DRM_MODE_ENCODER_TMDS, port_info->name);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to