Re: [Intel-gfx] [PATCH v2 14/17] drm/i915/pps: refactor init abstractions

Tue, 19 Jan 2021 20:20:55 -0800 


> -----Original Message-----
> From: Jani Nikula <[email protected]>
> Sent: Thursday, January 14, 2021 2:16 PM
> To: Gupta, Anshuman <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH v2 14/17] drm/i915/pps: refactor init abstractions
> 
> On Wed, 13 Jan 2021, Anshuman Gupta <[email protected]>
> wrote:
> > On 2021-01-08 at 19:44:22 +0200, Jani Nikula wrote:
> >> @@ -1366,20 +1352,21 @@ void intel_pps_encoder_reset(struct
> intel_dp *intel_dp)
> >>             * Reinit the power sequencer, in case BIOS did something
> nasty
> >             IMHO above comment would need a improvement, or nuke
> it ?
> >             as intel_pps_encoder_reset() will also get called from
> intel_pps_init()
> >             unlike only while resuming from suspend.
> 
> How about this?
> 
> -                * Reinit the power sequencer, in case BIOS did something 
> nasty
> -                * with it.
> +                * Reinit the power sequencer also on the resume path, in case
> +                * BIOS did something nasty with it.
> 
With that comment change.
Reviewed-by: Anshuman Gupta <[email protected]> 
> 
> BR,
> Jani.
> 
> 
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx























					Reply via email to