== Series Details ==
Series: series starting with [1/2] drm/i915/step: Add macro magic for handling
steps (rev2)
URL : https://patchwork.freedesktop.org/series/92560/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e95d63d8b4e0 drm/i915/step: Add macro magic for handling steps
-:24: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements
should be enclosed in a do - while loop
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name) \
+ case STEP_##name: \
+ return #name;
-:24: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name) \
+ case STEP_##name: \
+ return #name;
-:30: ERROR:SPACING: space required before the open parenthesis '('
#30: FILE: drivers/gpu/drm/i915/intel_step.c:192:
+ switch(step) {
-:33: ERROR:SPACING: space prohibited before that ':' (ctx:WxE)
#33: FILE: drivers/gpu/drm/i915/intel_step.c:195:
+ default :
^
-:47: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
parentheses
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func) \
+ func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0)
-:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible
side-effects?
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func) \
+ func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0)
total: 4 errors, 1 warnings, 1 checks, 70 lines checked
60161ed9f955 drm/i915/dmc: Change intel_get_stepping_info()
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
