2013/9/17 Ville Syrjälä <[email protected]>: > On Tue, Sep 17, 2013 at 05:24:01PM +0100, Chris Wilson wrote: >> On Tue, Sep 17, 2013 at 06:33:44PM +0300, [email protected] >> wrote: >> > From: Ville Syrjälä <[email protected]> >> > >> > On HSW enabling a plane on a disabled pipe may hang the entire system. >> > And there's no good reason for doing it ever, so just don't. >> > >> > v2: Move the crtc active checks to intel_crtc_cursor_{set,move} to >> > avoid confusing people during modeset >> >> But outside of modeset the existing checks are accurate. > > There are no existing checks anymore. The crtc->enabled check ended up > as collateral damage in the cursor visibility patches.
I'm not really an expert in the cursor code, but as far as I could understand, this patch looks correct. Reviewed-by: Paulo Zanoni <[email protected]> (I propose a "Weak-reviewed-by:" tag for cases like this!) Also, isn't this one of those cases where we can try to write an IGT test? (unset all modes, call the cursor IOCTLs) > > -- > Ville Syrjälä > Intel OTC > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
