On Wed, Sep 18, 2013 at 05:19:45PM +0300, Jani Nikula wrote: > Ville and I were wondering why his laptop was missing the > intel_backlight sysfs interface. Turns out we never register it when > CONFIG_BACKLIGHT_CLASS_DEVICE=m. This has been broken ever since the > i915 native backlight interface was added. > > CC: [email protected] > CC: Ville Syrjälä <[email protected]> > Signed-off-by: Jani Nikula <[email protected]>
FWIW, a quick git grep -e "#if.*def.*CONFIG" drivers/gpu/drm/i915/ did not return anything else of this kind. Reviewed-by: Damien Lespiau <[email protected]> -- Damien > --- > drivers/gpu/drm/i915/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c > b/drivers/gpu/drm/i915/intel_panel.c > index fdf9cb5..3bc89a6 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -659,7 +659,7 @@ intel_panel_detect(struct drm_device *dev) > } > } > > -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE > +#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > static int intel_panel_update_status(struct backlight_device *bd) > { > struct drm_device *dev = bl_get_data(bd); > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
