Re: [Intel-gfx] [PATCH 12/13] drm/i915/tc: Drop extra TC cold blocking from intel_tc_port_connected()

[Souza, Jose]

On Tue, 2021-09-21 at 03:23 +0300, Imre Deak wrote:
> After the previous patch the driver holds a power domain blocking
> TC-cold whenever the port is locked, so we can remove the extra blocking
> around the lock/unlock sequence.

Reviewed-by: José Roberto de Souza <jose.so...@intel.com>

> 
> Cc: José Roberto de Souza <jose.so...@intel.com>
> Signed-off-by: Imre Deak <imre.d...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_tc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c 
> b/drivers/gpu/drm/i915/display/intel_tc.c
> index 3fefd00e04685..99b66c2852e53 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -719,16 +719,12 @@ bool intel_tc_port_connected(struct intel_encoder 
> *encoder)
>  {
>       struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
>       bool is_connected;
> -     enum intel_display_power_domain domain;
> -     intel_wakeref_t tc_cold_wref;
>  
>       intel_tc_port_lock(dig_port);
> -     tc_cold_wref = tc_cold_block(dig_port, &domain);
>  
>       is_connected = tc_port_live_status_mask(dig_port) &
>                      BIT(dig_port->tc_mode);
>  
> -     tc_cold_unblock(dig_port, domain, tc_cold_wref);
>       intel_tc_port_unlock(dig_port);
>  
>       return is_connected;