On 10/13/2021 15:53, Dixit, Ashutosh wrote:
On Wed, 13 Oct 2021 15:43:17 -0700, <john.c.harri...@intel.com> wrote:
From: John Harrison <john.c.harri...@intel.com>
The gem_exec_fair test is specifically testing scheduler algorithm
performance. However, GuC does not implement the same algorithm as
execlist mode and this test is not applicable. So, until sw arch
approves a new algorithm and it is implemented in GuC, stop running
the test.
Signed-off-by: John Harrison <john.c.harri...@intel.com>
---
tests/i915/gem_exec_fair.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/i915/gem_exec_fair.c b/tests/i915/gem_exec_fair.c
index ef5a450f6..ca9c73c6e 100644
--- a/tests/i915/gem_exec_fair.c
+++ b/tests/i915/gem_exec_fair.c
@@ -1314,6 +1314,12 @@ igt_main
igt_require(gem_scheduler_enabled(i915));
igt_require(gem_scheduler_has_ctx_priority(i915));
+ /*
+ * These tests are for a specific scheduling model which is
+ * not currently implemented by GuC. So skip on GuC platforms.
+ */
+ igt_require(intel_gen(intel_get_drm_devid(i915)) < 12);
Probably a feature check rather than a version check is better? Can we use
say gem_has_guc_submission() instead?
Though appears gem_has_guc_submission() only checks if guc submission is
available, not if it is actually in use (unless guc will used when
available automatically)? Is it possible to add the check if guc submission
is actually in use? Or a check for guc scheduler?
I believe this has come up a few times before. My understanding is that
no, there is no current official/safe way for userland to check if GuC
submission is enabled (you can read some of the debugfs files and make
an educated guess but that isn't exactly an official interface). And the
answer was that it isn't worth adding a UAPI specifically for it. Not
least because it would be a UAPI solely for use by IGT which is not allowed.
John.
+
cfg = intel_ctx_cfg_all_physical(i915);
igt_info("CS timestamp frequency: %d\n",
--
2.25.1
