On Wed, Oct 16, 2013 at 10:55:45PM +0200, Daniel Vetter wrote: > Hi all, > > I've stitched together basic CRC support for non-ivb platforms. Still need to > do > a bit more testing on this, but ignoring bugs this should be it. We also need > to > pimp the igt testcase a bit so that it falls back to the new PIPE source if > the > PLANE1 source isn't available. > > Review and comments highly welcome.
Apart from the three minor things I commented on, I couldn't find any real problems with the series. So the remainder of the series is: Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Cheers, Daniel > > Daniel Vetter (16): > drm/i915: extract display_pipe_crc_update > drm/i915: add CRC #defines for ilk/snb > drm/i915: wire up CRC interrupt for ilk/snb > drm/i915: use ->get_vblank_counter for the crc frame counter > drm/i915: wait one vblank when disabling CRCs > drm/i915: fix CRC debugfs setup > drm/i915: crc support for hsw > drm/i915: Adjust CRC capture for pre-gen5/vlv > drm/i915: CRC source selection #defines for gmch/vlv chips > drm/i915: Wire up CRC interrupts for pre-gen5/vlv > drm/i915: Enable CRC interrupts on pre-gen5/vlv > drm/i915: Fix PIPE_CRC_CTL for vlv > drm/i915: Add new CRC sources > drm/i915: Wire up CRC support for gen3/4 > drm/i915: Wire up gen2 CRC support > drm/i915: Wire up CRC for vlv > > drivers/gpu/drm/i915/i915_debugfs.c | 164 > +++++++++++++++++++++++++++++++----- > drivers/gpu/drm/i915/i915_drv.h | 6 ++ > drivers/gpu/drm/i915/i915_irq.c | 151 +++++++++++++++++++++++++-------- > drivers/gpu/drm/i915/i915_reg.h | 74 +++++++++++++--- > 4 files changed, 328 insertions(+), 67 deletions(-) > > -- > 1.8.4.rc3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
