[Intel-gfx] [PATCH v11 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

[Alexander Usyskin]

Setup char device in spite of firmware handshake failure.
In order to provide host access to the firmware status registers and other
information required for the manufacturing process.

Signed-off-by: Alexander Usyskin <alexander.usys...@intel.com>
Signed-off-by: Tomas Winkler <tomas.wink...@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
---
V5: Rebase
V6: Rebase
V7: add Greg KH Reviewed-by
V8: Rebase
V9: Rebase
V11: Rebase
---
 drivers/misc/mei/gsc-me.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
index 64b02adf3149..58e39c00f150 100644
--- a/drivers/misc/mei/gsc-me.c
+++ b/drivers/misc/mei/gsc-me.c
@@ -79,11 +79,12 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
        pm_runtime_set_active(device);
        pm_runtime_enable(device);
 
-       if (mei_start(dev)) {
-               dev_err(device, "init hw failure.\n");
-               ret = -ENODEV;
-               goto irq_err;
-       }
+       /* Continue to char device setup in spite of firmware handshake failure.
+        * In order to provide access to the firmware status registers to the 
user
+        * space via sysfs.
+        */
+       if (mei_start(dev))
+               dev_warn(device, "init hw failure.\n");
 
        pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT);
        pm_runtime_use_autosuspend(device);
@@ -97,7 +98,6 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
 
 register_err:
        mei_stop(dev);
-irq_err:
        devm_free_irq(device, hw->irq, dev);
 
 err:
-- 
2.32.0